Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for python 3 #295

Closed
wants to merge 3 commits into from
Closed

Fix for python 3 #295

wants to merge 3 commits into from

Conversation

mikhuang
Copy link

Fix for TypeError: 'str' does not support the buffer interface when there's an ffmpeg error

@mikhuang
Update ffmpeg_writer.py
da1ec76 
Fix `TypeError: 'str' does not support the buffer interface` error
@mikhuang
Update ffmpeg_audiowriter.py
ca7f444
@mikhuang
Merge pull request #1 from mikhuang/mikhuang-str-buffer
ae89b47 
String buffer issue
@jeromegrosse jeromegrosse mentioned this pull request Oct 13, 2016
Closed
@mbeacom mbeacom mentioned this pull request Feb 14, 2017
Merged
@mbeacom
Copy link
Collaborator

mbeacom commented Feb 14, 2017

@mikhuang Thank you for your contribution! This looks like a good solution to resolve the exception, but I'm going to move ahead with #403, as it is addressing the py3 byte issue.

@mbeacom mbeacom closed this Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikhuang @mbeacom